From c927e68bfd5e070d666642de786a971b9f0330e9 Mon Sep 17 00:00:00 2001 From: Pascal Rigaux Date: Thu, 12 Aug 2004 04:46:01 +0000 Subject: you can replace "grep { !member($_, ...) } @l" with "difference2([ @l ], [ ... ])" --- perl_checker.src/test/suggest_better.t | 2 ++ 1 file changed, 2 insertions(+) (limited to 'perl_checker.src/test') diff --git a/perl_checker.src/test/suggest_better.t b/perl_checker.src/test/suggest_better.t index be238a2..d3af927 100644 --- a/perl_checker.src/test/suggest_better.t +++ b/perl_checker.src/test/suggest_better.t @@ -72,6 +72,8 @@ member($xxx, keys %h) you can replace "member($xxx, keys %yyy !($xxx eq 'foo') !($foo eq $bar) is better written $foo ne $bar +grep { !member($_, qw(a b c)) } @l you can replace "grep { !member($_, ...) } @l" with "difference2([ @l ], [ ... ])" + foreach (@l) { use "push @l2, grep { ... } ..." instead of "foreach (...) { push @l2, $_ if ... }" push @l2, $_ if yyy($_); or sometimes "@l2 = grep { ... } ..." } -- cgit v1.2.1