From 670835bee947e095d54f0bd15e53f6e98e48c26f Mon Sep 17 00:00:00 2001 From: Pascal Rigaux Date: Wed, 11 Aug 2004 07:02:34 +0000 Subject: "$foo or $foo = ..." can be written "$foo ||= ..." --- perl_checker.src/test/suggest_better.t | 2 ++ 1 file changed, 2 insertions(+) (limited to 'perl_checker.src/test') diff --git a/perl_checker.src/test/suggest_better.t b/perl_checker.src/test/suggest_better.t index 8d8cb37..be238a2 100644 --- a/perl_checker.src/test/suggest_better.t +++ b/perl_checker.src/test/suggest_better.t @@ -38,6 +38,8 @@ $o = xxx() if !$o; "$foo = ... if !$foo" can be written "$ $o = xxx() unless $o; "$foo = ... unless $foo" can be written "$foo ||= ..." +$o or $o = xxx(); "$foo or $foo = ..." can be written "$foo ||= ..." + $_ =~ s/xxx/yyy/ "$_ =~ s/regexp/.../" can be written "s/regexp/.../" $xxx =~ /^yyy$/ "... =~ /^yyy$/" is better written "... eq 'yyy'" -- cgit v1.2.1