diff options
| author | Pascal Rigaux <pixel@mandriva.com> | 2003-02-13 11:09:42 +0000 |
|---|---|---|
| committer | Pascal Rigaux <pixel@mandriva.com> | 2003-02-13 11:09:42 +0000 |
| commit | f1d3c94733bf7c98f5954245369ea8483d5d87f3 (patch) | |
| tree | bc2e4ce47053758ac3efaa368dd3fcd7bb3b961b /perl_checker.src | |
| parent | 0ab12edf5563bfdaeec0427be9a63088fe08bcbc (diff) | |
| download | perl_checker-f1d3c94733bf7c98f5954245369ea8483d5d87f3.tar perl_checker-f1d3c94733bf7c98f5954245369ea8483d5d87f3.tar.gz perl_checker-f1d3c94733bf7c98f5954245369ea8483d5d87f3.tar.bz2 perl_checker-f1d3c94733bf7c98f5954245369ea8483d5d87f3.tar.xz perl_checker-f1d3c94733bf7c98f5954245369ea8483d5d87f3.zip | |
check use of variables with name _XXX (reserved for unused variables)
Diffstat (limited to 'perl_checker.src')
| -rw-r--r-- | perl_checker.src/global_checks.ml | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/perl_checker.src/global_checks.ml b/perl_checker.src/global_checks.ml index f94309a..579e2ae 100644 --- a/perl_checker.src/global_checks.ml +++ b/perl_checker.src/global_checks.ml @@ -75,6 +75,7 @@ and get_imports state package = package.imported := Some l ; l +let is_anonymous_variable_name s = String.length s > 1 && s.[0] = '_' let is_my_declared vars t = List.exists (fun l -> @@ -138,7 +139,7 @@ let is_global_var context ident = | "defined" | "delete" | "die" | "each" | "endpwent" | "eof" | "eval" | "exec" | "exists" | "exit" | "fcntl" | "fileno" | "flock" | "formline" | "fork" - | "gethostbyaddr" | "gethostbyname" | "getgrnam" | "getgrgid" | "getppid" | "getpwent" | "getpwnam" | "getpwuid" | "gmtime" | "goto" | "grep" | "hex" + | "gethostbyaddr" | "gethostbyname" | "getgrnam" | "getgrgid" | "getppid" | "getpwent" | "getpwnam" | "getpwuid" | "glob" | "gmtime" | "goto" | "grep" | "hex" | "index" | "int" | "ioctl" | "join" | "keys" | "kill" | "last" | "lc" | "lcfirst" | "length" | "link" | "localtime" | "log" | "lstat" | "map" | "mkdir" | "next" | "no" | "oct" | "open" | "opendir" | "ord" @@ -154,6 +155,8 @@ let is_global_var context ident = let check_variable (context, var) vars = match var with + | Ident(_, s, pos) when context <> I_func && is_anonymous_variable_name s && s <> "__FILE__" && s <> "__LINE__" -> + warn_with_pos pos (sprintf "variable %s must not be used\n (variable with name _XXX are reserved for unused variables)" (variable2s(context, string_of_Ident var))) | Ident(Some pkg, _, _) when uses_external_package pkg || List.mem pkg !ignored_packages -> () | Ident(None, ident, pos) -> if is_my_declared vars (context, ident) || is_our_declared vars (context, ident) || is_var_declared vars (context, ident) || is_global_var context ident |