diff options
| author | Pascal Rigaux <pixel@mandriva.com> | 2004-10-14 05:06:52 +0000 |
|---|---|---|
| committer | Pascal Rigaux <pixel@mandriva.com> | 2004-10-14 05:06:52 +0000 |
| commit | d796a03012be18aad75008fec86ba90bf1d3c513 (patch) | |
| tree | 29251fd9ff59d58599b206ebd941d5f1d1613966 /perl_checker.src/test | |
| parent | b5c54309bae69c9c0c8fd02245a79b2da468464e (diff) | |
| download | perl_checker-d796a03012be18aad75008fec86ba90bf1d3c513.tar perl_checker-d796a03012be18aad75008fec86ba90bf1d3c513.tar.gz perl_checker-d796a03012be18aad75008fec86ba90bf1d3c513.tar.bz2 perl_checker-d796a03012be18aad75008fec86ba90bf1d3c513.tar.xz perl_checker-d796a03012be18aad75008fec86ba90bf1d3c513.zip | |
suggest mkdir() instead of system("mkdir ...")
Diffstat (limited to 'perl_checker.src/test')
| -rw-r--r-- | perl_checker.src/test/suggest_better.t | 3 | ||||
| -rw-r--r-- | perl_checker.src/test/various_errors.t | 2 |
2 files changed, 3 insertions, 2 deletions
diff --git a/perl_checker.src/test/suggest_better.t b/perl_checker.src/test/suggest_better.t index 4b8d2d5..e98e64f 100644 --- a/perl_checker.src/test/suggest_better.t +++ b/perl_checker.src/test/suggest_better.t @@ -100,3 +100,6 @@ $xxx ? $yyy : () you may use if_() here beware that the short-circuit semantic of ?: is not kept if you want to keep the short-circuit behaviour, replace () with @{[]} and there will be no warning anymore +system(qq(foo "$xxx")) instead of quoting parameters you should give a list of arguments + +system("mkdir", $xxx) you can replace system("mkdir ...") with mkdir(...) diff --git a/perl_checker.src/test/various_errors.t b/perl_checker.src/test/various_errors.t index f9c4089..dfac926 100644 --- a/perl_checker.src/test/various_errors.t +++ b/perl_checker.src/test/various_errors.t @@ -39,8 +39,6 @@ pop @l, 1 pop is expecting an array and nothing e pop $xxx pop is expecting an array and nothing else -system(qq(foo "$xxx")) instead of quoting parameters you should give a list of arguments - my (@l2, $xxx) = @l; @l2 takes all the arguments, $xxx is undef in any case $bad undeclared variable $bad |