add tests for perl_checker

1 files changed, 52 insertions, 0 deletions

diff --git a/perl_checker.src/test/syntax_restrictions.t b/perl_checker.src/test/syntax_restrictions.t
new file mode 100644
index 0000000..6c336be
--- /dev/null
+++ b/perl_checker.src/test/syntax_restrictions.t
@@ -0,0 +1,52 @@
+$xxx <<= 2                               don't use "<<=", use the expanded version instead
+
+m@xxx@                                   don't use m@...@, replace @ with / ! , or |
+
+qx(xxx)                                  don't use qx{...}, use `...` instead
+
+not $xxx                                 don't use "not", use "!" instead
+
+$1 =~ /xxx/                              do not use the result of a match (eg: $1) to match another pattern
+
+$xxx =~ "yyy"                            use a regexp, not a string
+
+xxx() =~ s/xxx/yyy/                      you can only use s/// on a variable
+
+$1 =~ /xxx/                              do not use the result of a match (eg: $1) to match another pattern
+
+grep /xxx/, @l                           always use "grep" with a block (eg: grep { ... } @list)
+
+for (@l) {}                              write "foreach" instead of "for"
+
+foreach ($xxx = 0; $xxx < 9; $xxx++) {}  write "for" instead of "foreach"
+
+foreach $xxx (@l) {}                     don't use for without "my"ing the iteration variable
+
+foreach ($xxx) {}                        you are using the special fpons trick to locally set $_ with a value, for this please use "for" instead of "foreach"
+
+unless ($xxx) {} else {}                 don't use "else" with "unless" (replace "unless" with "if")
+
+unless ($xxx) {} elsif ($yyy) {}         don't use "elsif" with "unless" (replace "unless" with "if")
+
+zzz() unless $xxx || $yyy;               don't use "unless" when the condition is complex, use "if" instead
+
+$$xxx{yyy}                               for complex dereferencing, use "->"
+
+wantarray                                please use wantarray() instead of wantarray
+
+eval                                     please use "eval $_" instead of "eval"
+
+$xxx !~ s/xxx/yyy/                       use =~ instead of !~ and negate the return value
+
+pkg::nop $xxx;                           use parentheses around argument (otherwise it might cause syntax errors if the package is "require"d and not "use"d
+
+new foo $xxx                             you must parenthesize parameters: "new Class(...)" instead of "new Class ..."
+
+*xxx = *yyy                              "*xxx = *yyy" is better written "*xxx = \&yyy"
+
+$_xxx = 1                                variable $_xxx must not be used
+                                           (variable with name _XXX are reserved for unused variables)
+
+sub f2 { my ($x, $_y) = @_; $x }         not enough parameters
+f2(@l);    # ok
+f2(xxx()); # bad