diff options
| author | Pascal Rigaux <pixel@mandriva.com> | 2003-05-23 13:50:38 +0000 |
|---|---|---|
| committer | Pascal Rigaux <pixel@mandriva.com> | 2003-05-23 13:50:38 +0000 |
| commit | f195e07e4d7585367905ce8bfac776e176a0b670 (patch) | |
| tree | 3341ffd35841cfa19d863d714a4cb792ad549223 | |
| parent | 23d1206401f04a5445f66a56bb7fd487ae8083e0 (diff) | |
| download | perl_checker-f195e07e4d7585367905ce8bfac776e176a0b670.tar perl_checker-f195e07e4d7585367905ce8bfac776e176a0b670.tar.gz perl_checker-f195e07e4d7585367905ce8bfac776e176a0b670.tar.bz2 perl_checker-f195e07e4d7585367905ce8bfac776e176a0b670.tar.xz perl_checker-f195e07e4d7585367905ce8bfac776e176a0b670.zip | |
add warning: you can replace "map { if_(..., $_) }" with "grep { ... }"
| -rw-r--r-- | perl_checker.src/parser_helper.ml | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/perl_checker.src/parser_helper.ml b/perl_checker.src/parser_helper.ml index e19dfe1..372f8a3 100644 --- a/perl_checker.src/parser_helper.ml +++ b/perl_checker.src/parser_helper.ml @@ -763,6 +763,10 @@ let call_func is_a_func (e, para) = | "map" | "grep" -> (match para with + + | Anonymous_sub(None, Block [ List [ Call(Deref(I_func, Ident(None, "if_", _)), + [ List [ _ ; Deref(I_scalar, Ident(None, "_", _)) ] ]) ] ], _) :: _ -> + warn_rule "you can replace \"map { if_(..., $_) }\" with \"grep { ... }\"" | Anonymous_sub _ :: _ -> () | _ -> warn_rule (sprintf "always use \"%s\" with a block (eg: %s { ... } @list)" f f)); None |