aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorLukas Nykryn <lnykryn@redhat.com>2016-05-30 13:40:53 +0200
committerLukas Nykryn <lnykryn@redhat.com>2016-05-30 13:40:53 +0200
commitee0eb388018636443799a9fa88eee47c86ab1565 (patch)
tree1cb0ca6502944f0ac72f572171c21436bd412f69
parenteacf0e68acd1f0da0ff1c789da411bb815e1c032 (diff)
downloadinitscripts-ee0eb388018636443799a9fa88eee47c86ab1565.tar
initscripts-ee0eb388018636443799a9fa88eee47c86ab1565.tar.gz
initscripts-ee0eb388018636443799a9fa88eee47c86ab1565.tar.bz2
initscripts-ee0eb388018636443799a9fa88eee47c86ab1565.tar.xz
initscripts-ee0eb388018636443799a9fa88eee47c86ab1565.zip
ipcalc: detect invalid mask
Resolves: #1318322
-rw-r--r--src/ipcalc.c7
1 files changed, 7 insertions, 0 deletions
diff --git a/src/ipcalc.c b/src/ipcalc.c
index 9108e4c2..2efb339f 100644
--- a/src/ipcalc.c
+++ b/src/ipcalc.c
@@ -107,6 +107,8 @@ int mask2prefix(struct in_addr mask)
uint32_t saddr = ntohl(mask.s_addr);
for (count=0; saddr > 0; count++) {
+ if (!((1 << 31) & saddr))
+ return -1;
saddr=saddr << 1;
}
@@ -339,6 +341,11 @@ int main(int argc, const char **argv) {
return 1;
}
prefix = mask2prefix(netmask);
+ if (prefix < 0 ) {
+ if (!beSilent)
+ fprintf(stderr, "ipcalc: bad netmask: %s\n", netmaskStr);
+ return 1;
+ }
}
}