From e4a78f9f5dfc2d9255d963fd518a5f00cb5c4e3f Mon Sep 17 00:00:00 2001 From: Rafael Garcia-Suarez Date: Wed, 15 Feb 2006 10:45:44 +0000 Subject: Fix another couple of potential buffer overflows --- mdk-stage1/url.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) (limited to 'mdk-stage1/url.c') diff --git a/mdk-stage1/url.c b/mdk-stage1/url.c index ea155419c..808bfd057 100644 --- a/mdk-stage1/url.c +++ b/mdk-stage1/url.c @@ -136,13 +136,7 @@ static int ftp_command(int sock, char * command, char * param) char buf[500]; int rc; - strcpy(buf, command); - if (param) { - strcat(buf, " "); - strcat(buf, param); - } - - strcat(buf, "\r\n"); + snprintf(buf, sizeof(buf), "%s%s%s\r\n", command, param ? " " : "", param ? param : ""); if (write(sock, buf, strlen(buf)) != (ssize_t)strlen(buf)) { return FTPERR_SERVER_IO_ERROR; -- cgit v1.2.1