From 6c1837a6cb4385ae75c67028e84ad8dcac2c2ad9 Mon Sep 17 00:00:00 2001 From: Thierry Vignaud Date: Wed, 25 Feb 2009 09:28:44 +0000 Subject: (config_window) remove empty module parameter instead of writing them (#40581) --- perl-install/NEWS | 2 ++ perl-install/modules/interactive.pm | 5 +++-- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/perl-install/NEWS b/perl-install/NEWS index f8fa8512c..e2b787e3c 100644 --- a/perl-install/NEWS +++ b/perl-install/NEWS @@ -1,3 +1,5 @@ +- harddrake: + o remove empty module parameter instead of writing them (#40581) - harddrake service: o prevent wrongly notifying we switched from proprietary to free driver (anssi, #41969) diff --git a/perl-install/modules/interactive.pm b/perl-install/modules/interactive.pm index f3b26f218..6bdbfb3b5 100644 --- a/perl-install/modules/interactive.pm +++ b/perl-install/modules/interactive.pm @@ -20,8 +20,9 @@ sub config_window { return; } if ($in->ask_from(N("Module configuration"), N("You can configure each parameter of the module here."), \@l)) { - my $options = join(' ', map { if_(defined $conf{$_}, "$_=$conf{$_}") } keys %conf); - if ($options) { + my $options = join(' ', map { if_($conf{$_}, "$_=$conf{$_}") } keys %conf); + my $old_options = $modules_conf->get_options($data->{driver}); + if ($options ne $old_options) { $modules_conf->set_options($data->{driver}, $options); $modules_conf->write; } -- cgit v1.2.1