From f7d861d97fa97f41f595fed19236bbbea6ec82b7 Mon Sep 17 00:00:00 2001 From: Olivier Blin Date: Fri, 23 May 2008 09:52:24 +0000 Subject: extract get_chat_file sub --- lib/network/connection/ppp.pm | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) (limited to 'lib/network/connection/ppp.pm') diff --git a/lib/network/connection/ppp.pm b/lib/network/connection/ppp.pm index 496ccda..78eafa8 100644 --- a/lib/network/connection/ppp.pm +++ b/lib/network/connection/ppp.pm @@ -93,11 +93,14 @@ sub build_chat { ); } +sub get_chat_file { + my ($self) = @_; + "/etc/sysconfig/network-scripts/chat-" . $self->get_interface; +} + sub write_chat { my ($self) = @_; - my $interface = $self->get_interface; - my $chat_file = "/etc/sysconfig/network-scripts/chat-$interface"; - output_with_perm($::prefix . $chat_file, 0755, join("\n", $self->build_chat, '')); + output_with_perm($::prefix . $self->get_chat_file, 0755, join("\n", $self->build_chat, '')); } sub get_peer_default_options { @@ -113,8 +116,7 @@ sub build_peer { #- pty #- plugin if ($self->{access}{dial_number}) { - my $interface = $self->get_interface; - my $chat_file = "/etc/sysconfig/network-scripts/chat-$interface"; + my $chat_file = $self->get_chat_file; $self->{access}{peer}{connect} ||= qq("/usr/sbin/chat -v -f $chat_file"); } $self->get_peer_default_options, -- cgit v1.2.1