From c1f70e7c8baf34fbf70d1f0b2baeed92e02108bb Mon Sep 17 00:00:00 2001 From: Angelo Naselli Date: Fri, 7 Nov 2014 17:18:11 +0100 Subject: code reviewed for showing/hidding info option --- modules/rpmdragora/dragoraUpdate | 15 +++------------ modules/rpmdragora/rpmdragora | 5 ++--- 2 files changed, 5 insertions(+), 15 deletions(-) (limited to 'modules') diff --git a/modules/rpmdragora/dragoraUpdate b/modules/rpmdragora/dragoraUpdate index d2ccd02..5b20ed7 100755 --- a/modules/rpmdragora/dragoraUpdate +++ b/modules/rpmdragora/dragoraUpdate @@ -267,18 +267,9 @@ sub run_treeview_dialog { if (!$item) { #URL emitted or at least a ref into RichText widget my $url = yui::toYMenuEvent($event)->id (); - $item = $packageTbl->selectedItem(); - my $pkg = $data{$item->index()}{fullname}; - if ($url eq $AdminPanel::Rpmdragora::gui::hidden_info{details}) { - $info_options->{details} = $info_options->{details} ? 0 : 1; - AdminPanel::Rpmdragora::gui::setInfoOnWidget($pkg, $infoBox, $info_options); - } - elsif ($url eq $AdminPanel::Rpmdragora::gui::hidden_info{files}) { - $info_options->{files} = $info_options->{files} ? 0 : 1; - AdminPanel::Rpmdragora::gui::setInfoOnWidget($pkg, $infoBox, $info_options); - } - elsif ($url eq $AdminPanel::Rpmdragora::gui::hidden_info{changelog}) { - $info_options->{changelog} = $info_options->{changelog} ? 0 : 1; + if (AdminPanel::Rpmdragora::gui::info_details($url, $info_options) ) { + $item = $packageTbl->selectedItem(); + my $pkg = $data{$item->index()}{fullname}; AdminPanel::Rpmdragora::gui::setInfoOnWidget($pkg, $infoBox, $info_options); } else { diff --git a/modules/rpmdragora/rpmdragora b/modules/rpmdragora/rpmdragora index 5d7a847..503e22d 100755 --- a/modules/rpmdragora/rpmdragora +++ b/modules/rpmdragora/rpmdragora @@ -1103,9 +1103,8 @@ sub run_treeview_dialog { if (!$item) { #URL emitted or at least a ref into RichText widget my $url = yui::toYMenuEvent($event)->id (); - $item = $detail_list->selectedItem(); - if ($url eq $AdminPanel::Rpmdragora::gui::hidden_info{details}) { - $info_options->{details} = $info_options->{details} ? 0 : 1; + if (AdminPanel::Rpmdragora::gui::info_details($url, $info_options) ) { + $item = $detail_list->selectedItem(); detaillist_callback($item, $info, \%$options, $info_options); } else { -- cgit v1.2.1