aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authormatteo <matteo.pasotti@gmail.com>2014-07-04 01:01:56 +0300
committermatteo <matteo.pasotti@gmail.com>2014-07-04 01:01:56 +0300
commitab285ca850f4ee2c7ea5bcb50039bdffe89a537c (patch)
tree67236821cf80c5bb536fa3f897e7544aaac0b31a
parentac042acd86ec3193d608e42a1dc5f71f585de7dd (diff)
downloadcolin-keep-ab285ca850f4ee2c7ea5bcb50039bdffe89a537c.tar
colin-keep-ab285ca850f4ee2c7ea5bcb50039bdffe89a537c.tar.gz
colin-keep-ab285ca850f4ee2c7ea5bcb50039bdffe89a537c.tar.bz2
colin-keep-ab285ca850f4ee2c7ea5bcb50039bdffe89a537c.tar.xz
colin-keep-ab285ca850f4ee2c7ea5bcb50039bdffe89a537c.zip
fixed warning about uninitialized value in string
-rw-r--r--lib/AdminPanel/Module/Proxy.pm9
1 files changed, 8 insertions, 1 deletions
diff --git a/lib/AdminPanel/Module/Proxy.pm b/lib/AdminPanel/Module/Proxy.pm
index c801106..afe7736 100644
--- a/lib/AdminPanel/Module/Proxy.pm
+++ b/lib/AdminPanel/Module/Proxy.pm
@@ -186,8 +186,15 @@ sub _manageProxyDialog {
my $label_width = 25;
my $inputfield_width = 45;
# getVarsFromSh returns an empty hash if no vars are defined
+ # possible alternatives:
+ # . Config::Auto::parse
my $proxy_curr_settings = { getVarsFromSh('/etc/profile.d/proxy.sh') };
- my $httpsProxyEqualToHttpProxy = 1 if(($proxy_curr_settings->{http_proxy} eq $proxy_curr_settings->{https_proxy})&&($proxy_curr_settings->{http_proxy} ne ""));
+ my $httpsProxyEqualToHttpProxy = 0;
+ if((defined($proxy_curr_settings->{http_proxy}) && defined($proxy_curr_settings->{https_proxy}))&&
+ (($proxy_curr_settings->{http_proxy} eq $proxy_curr_settings->{https_proxy}) &&
+ ($proxy_curr_settings->{http_proxy} ne ""))){
+ $httpsProxyEqualToHttpProxy = 1;
+ }
#
# @layout