From 1900524954037f7665e5331db6b48db17f17966b Mon Sep 17 00:00:00 2001 From: Bogdano Arendartchuk Date: Fri, 21 Jul 2006 23:49:05 +0000 Subject: - changed behavior of the pysvn wrapper to return None instead of False, it is more appropriate to report "errors" - fixed bug in which wrapper's log was not checking if the wrapped call to pysvn's log returned None (silented error). --- RepSys/svn.py | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/RepSys/svn.py b/RepSys/svn.py index 0362683..aefb8ea 100644 --- a/RepSys/svn.py +++ b/RepSys/svn.py @@ -54,7 +54,7 @@ class SVN: except pysvn.ClientError: if not ignore_errors: raise - return False + return None finally: self._current_message = None self._client_lock.release() @@ -91,6 +91,8 @@ class SVN: def log(self, *args, **kwargs): meth = self.__getattr__("log") entries = meth(*args, **kwargs) + if entries is None: + return for entrydic in entries: entry = SVNLogEntry(entrydic["revision"].number, entrydic["author"], @@ -99,7 +101,7 @@ class SVN: yield entry def exists(self, path): - return self.ls(path, noerror=1) is not False + return self.ls(path, noerror=1) is not None def _edit_message(self, message): # argh! -- cgit v1.2.1