From e9fe96e5d2a9c3245aca5728ae62d54a1dea8ffa Mon Sep 17 00:00:00 2001 From: Olivier Blin Date: Thu, 13 Jan 2011 12:42:41 +0000 Subject: add missing parentheses in open calls --- lib/Iurt/Chroot.pm | 2 +- lib/Iurt/DKMS.pm | 2 +- lib/Iurt/Process.pm | 2 +- lib/Iurt/Urpmi.pm | 4 ++-- 4 files changed, 5 insertions(+), 5 deletions(-) (limited to 'lib') diff --git a/lib/Iurt/Chroot.pm b/lib/Iurt/Chroot.pm index 6464f49..7b18acc 100644 --- a/lib/Iurt/Chroot.pm +++ b/lib/Iurt/Chroot.pm @@ -287,7 +287,7 @@ sub remove_chroot { plog('DEBUG', "... dir $dir all $run->{clean_all} prefix $prefix"); if ($run->{clean_all}) { - opendir my $chroot_dir, $dir; + opendir(my $chroot_dir, $dir); foreach (readdir $chroot_dir) { next if !-d "$dir/$_" || /\.{1,2}/; plog("cleaning old chroot for $_ in $dir"); diff --git a/lib/Iurt/DKMS.pm b/lib/Iurt/DKMS.pm index 39a3319..7410008 100644 --- a/lib/Iurt/DKMS.pm +++ b/lib/Iurt/DKMS.pm @@ -67,7 +67,7 @@ sub search_dkms { my $media_ok = $run->{dkms}{media} ? $media =~ /$run->{dkms}{media}/ : 1; my $kmedia_ok = $run->{dkms}{kmedia} ? $media =~ /$run->{dkms}{kmedia}/ : 1; plog("searching in $path"); - opendir my $rpmdh, $path; + opendir(my $rpmdh, $path); foreach my $rpm (readdir $rpmdh) { if ($rpm =~ /^dkms-(.*)-([^-]+-[^-]+)\.[^.]+\.rpm/) { # we only check for kernel or modules in this media diff --git a/lib/Iurt/Process.pm b/lib/Iurt/Process.pm index 9855b36..fa8883b 100644 --- a/lib/Iurt/Process.pm +++ b/lib/Iurt/Process.pm @@ -44,7 +44,7 @@ sub check_pid { if (-f $pidfile) { my (@stat) = stat $pidfile; - open my $test_PID, $pidfile; + open(my $test_PID, $pidfile); my $pid = <$test_PID>; close $test_PID; diff --git a/lib/Iurt/Urpmi.pm b/lib/Iurt/Urpmi.pm index d8c58c6..2559287 100644 --- a/lib/Iurt/Urpmi.pm +++ b/lib/Iurt/Urpmi.pm @@ -157,7 +157,7 @@ sub urpmi_command { if (-d $local_media) { mkdir("$chroot_tmp/iurt_media/"); - opendir my $dir, $local_media; + opendir(my $dir, $local_media); my $next; foreach my $f (readdir $dir) { $f =~ /(\.rpm|^hdlist.cz)$/ or next; @@ -268,7 +268,7 @@ sub get_local_provides { my $program_name = $run->{program_name}; my $local_media = $self->{local_media}; - opendir my $dir, $local_media; + opendir(my $dir, $local_media); plog(1, "get local provides ($local_media)"); require URPM; my $urpm = new URPM; -- cgit v1.2.1