From 9a8ca6c1f42cf96bdac0015617d79a11561a6c55 Mon Sep 17 00:00:00 2001 From: Thierry Vignaud Date: Tue, 25 Sep 2012 06:23:29 +0000 Subject: simplify --- emi | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) (limited to 'emi') diff --git a/emi b/emi index c56236a..caf5b2b 100755 --- a/emi +++ b/emi @@ -277,13 +277,9 @@ sub upload_prefix_in_section { my ($user) = $prefix =~ /\d{14}\.(\w+)\.\w+\.\d+/; if ($user) { - my $text = qq(The upload of the following packages failed:\n); - my $rpms; - foreach my $rpm (@{$pkg_tree{$prefix}{section}{$section}{rpms}}) { - $rpm =~ /src\.rpm$/ or next; - $rpms .= "$rpm "; - $text .= "- $rpm\n"; - } + my @pkgs = grep { !/src\.rpm$/ } @{$pkg_tree{$prefix}{section}{$section}{rpms}}; + my $text = join("\n", qq(The upload of the following packages failed:\n), map { "- $_" } @pkgs) . "\n"; + my $rpms = join(' ', @pkgs, undef); my $to = get_author_email($user) || "Unknown <$config->{admin}>"; my $cc; $text .= "\nUpload log available in $config->{http_queue}/rejected/$path/$prefix.youri\n"; -- cgit v1.2.1