aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
-rw-r--r--NEWS3
-rw-r--r--lib/Iurt/Urpmi.pm2
2 files changed, 4 insertions, 1 deletions
diff --git a/NEWS b/NEWS
index f6310bf..0092584 100644
--- a/NEWS
+++ b/NEWS
@@ -2,6 +2,9 @@
- Add some tests checking the syntax of iurt/ulri/emi as the main scripts
are not covered by test.
- ulri: Fix syntax
+- iurt: Fix build system retrying forever when rpmbuild -br fails to compute
+ dynamic BuildRequires, for example because some BuildRequires used in %prep
+ are missing.
0.8.1
- iurt: Fix getting a retriable install_deps_failure instead of missing_dep
diff --git a/lib/Iurt/Urpmi.pm b/lib/Iurt/Urpmi.pm
index 49025d8..53d0756 100644
--- a/lib/Iurt/Urpmi.pm
+++ b/lib/Iurt/Urpmi.pm
@@ -584,7 +584,6 @@ sub install_dynamic_buildrequires {
use_iurt_root_command => 1,
hash => "generatebuildrequires_$srpm"
);
-
return 1 if $ret;
# Unfortunately iurt_root_command hides the original error code so
@@ -611,6 +610,7 @@ sub install_dynamic_buildrequires {
} else {
# This was a failure for another reason, no point retrying
plog('ERROR', "Failed to generate dynamic BuildRequires.");
+ $run->{status}{$srpm} = 'build_failure';
return 0;
}
}