aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorPascal Terjan <pterjan@mageia.org>2022-08-22 18:04:52 +0000
committerPascal Terjan <pterjan@mageia.org>2022-08-22 18:09:21 +0000
commitc114af47702012d3c60b9b4f252f6c52b225d074 (patch)
tree881b7d927e12bddde407ea8aeb836383535544fe
parentb79f3a537c62c4f1d987ccf33ab38cddeb3d1d9d (diff)
downloadiurt-c114af47702012d3c60b9b4f252f6c52b225d074.tar
iurt-c114af47702012d3c60b9b4f252f6c52b225d074.tar.gz
iurt-c114af47702012d3c60b9b4f252f6c52b225d074.tar.bz2
iurt-c114af47702012d3c60b9b4f252f6c52b225d074.tar.xz
iurt-c114af47702012d3c60b9b4f252f6c52b225d074.zip
Fix false positives of iurt dying on the build machine
sout("foo || bar") was fetching the output of: ssh -x user@host foo || bar instead of: ssh -x user@host "foo || bar" This means we were considering the remote command to have failed when ssh to the machine to check status was failing.
-rw-r--r--NEWS1
-rw-r--r--lib/Iurt/Util.pm2
2 files changed, 2 insertions, 1 deletions
diff --git a/NEWS b/NEWS
index a126dd3..37a4f38 100644
--- a/NEWS
+++ b/NEWS
@@ -1,3 +1,4 @@
+- ulri: Fix false positives of iurt dying on the build machine
- Fix cleaning chroots (eg: when using --clean-all)
0.7.17.2
diff --git a/lib/Iurt/Util.pm b/lib/Iurt/Util.pm
index f9dfa9f..bf726d0 100644
--- a/lib/Iurt/Util.pm
+++ b/lib/Iurt/Util.pm
@@ -167,7 +167,7 @@ execute I<@command>. Return the command output.
sub sout {
my $conf = shift;
my ($opt, $user, $host) = @$conf;
- `ssh $opt -x $user\@$host @_ 2>/dev/null`;
+ `ssh $opt -x $user\@$host "@_" 2>/dev/null`;
}
=item sget($handle, $from, $to)