make puppet-lint happier, and use short form option for puppet invocation

1 files changed, 11 insertions, 13 deletions

diff --git a/modules/puppet/manifests/client.pp b/modules/puppet/manifests/client.pp
index 6f344165..55894d9b 100644
--- a/modules/puppet/manifests/client.pp
+++ b/modules/puppet/manifests/client.pp
@@ -1,23 +1,21 @@
 class puppet::client {
-    package { puppet: }
+    package { 'puppet': }
 
-    file { "/etc/puppet/puppet.conf":
-        content => template("puppet/puppet.conf"),
-        require => Package[puppet]
+    file { '/etc/puppet/puppet.conf':
+        content => template('puppet/puppet.conf'),
+        require => Package[puppet],
     }
 
-    cron { "puppet":
-        command => "/usr/sbin/puppetd --onetime --no-daemonize --logdest syslog > /dev/null 2>&1",
-        user => "root",
-        minute => fqdn_rand( 60 ),
-        ensure => present,
+    cron { 'puppet':
+        ensure  => present,
+        command => '/usr/sbin/puppetd -o --no-daemonize -l syslog >/dev/null 2>&1',
+        user    => 'root',
+        minute  => fqdn_rand( 60 ),
     }
 
     # we are using cron, so no need for the service
-    service { puppet:
-        enable => false,
+    service { 'puppet':
+        enable    => false,
         hasstatus => true,
     }
 }
-
-